tscircuit community
← Back to community index
# contributor·Active

Rishabh - https://github.com/tscircuit/core/pul...

https://github.com/tscircuit/core/pull/4959 https://github.com/tscircuit/footprinter/pull/976 I don't know why footprinter was responsible for the fabrication notes about the polarity, core should be the one which is having info and generates the fabrication notes. Refactored her

Started by RishabhOct 27, 202623 messages

Discussion

Last active 1 hour ago · plain text
Rishabhoriginal post
https://github.com/tscircuit/core/pull/4959 https://github.com/tscircuit/footprinter/pull/976 I don't know why footprinter was responsible for the fabrication notes about the polarity, core should be the one which is having info and generates the fabrication notes. Refactored here <@757706909351411845>
Seve
hmm
Seve
historically it is kind of owned by the footprint
Seve
why do you want to move it
Rishabh
I am seeing a normal `<chip footprint="sod882" />` is adding a diode symbol
Seve
yea i think some contributor added that
Rishabh
Cause of duplicates
Seve
it should be more intelligent
Seve
but i don't think this fix makes sense tho
Seve
sod882 should default to not having fabrication notes if it's not always used for diodes
Seve
however
Seve
sod = Small Outline Diode
Seve
yea i'm not sure about this
Seve
we could just detect when a footprint is not polarized and add `_nonpolarized`, we do that with some footprints
Rishabh
My confusion is, footprinter defines the physical footprint. core knows the component’s electrical meaning. Polarity instructions belong in core because the same footprint can hold components with different polarity requirements.
Rishabh
Also, when I was updating footprinter with my fix. I saw duplicate symbols
Seve
so core sometimes "injects things" into footprinter strings. I think we might need to automatically detect fabrication notes possibly
Seve
if you want to discuss in voice i'm around
Seve
idk
Seve
you have a good point
Seve
but i also think footprints can come with fabrication notes
Seve
and changing footprints in core
Rishabh
joining

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗