# Rishabh - https://github.com/tscircuit/core/pul...

Channel: #contributor
Source: https://discord.com/channels/1233487248129921135/1564671269675212861
Started: 2026-10-27T16:05:01.376000+00:00
Last activity: 2026-10-27T16:32:10.780000+00:00

## Rishabh — 2026-10-27T16:05:00.877000+00:00

https://github.com/tscircuit/core/pull/4959
https://github.com/tscircuit/footprinter/pull/976

I don't know why footprinter was responsible for the fabrication notes about the polarity, core should be the one which is having info and generates the fabrication notes. Refactored here

<@757706909351411845>

## Seve — 2026-10-27T16:06:25.692000+00:00

hmm

## Seve — 2026-10-27T16:06:33.683000+00:00

historically it is kind of owned by the footprint

## Seve — 2026-10-27T16:07:21.506000+00:00

why do you want to move it

## Rishabh — 2026-10-27T16:07:36.001000+00:00

I am seeing a normal `<chip footprint="sod882" />` is adding a diode symbol

## Seve — 2026-10-27T16:07:51.036000+00:00

yea i think some contributor added that

## Rishabh — 2026-10-27T16:07:55.183000+00:00

Cause of duplicates

## Seve — 2026-10-27T16:07:59.049000+00:00

it should be more intelligent

## Seve — 2026-10-27T16:08:04.592000+00:00

but i don't think this fix makes sense tho

## Seve — 2026-10-27T16:09:01.276000+00:00

sod882 should default to not having fabrication notes if it's not always used for diodes

## Seve — 2026-10-27T16:09:02.842000+00:00

however

## Seve — 2026-10-27T16:09:09.829000+00:00

sod = Small Outline Diode

## Seve — 2026-10-27T16:09:14.536000+00:00

yea i'm not sure about this

## Seve — 2026-10-27T16:10:13.183000+00:00

we could just detect when a footprint is not polarized and add `_nonpolarized`, we do that with some footprints

## Rishabh — 2026-10-27T16:12:23.384000+00:00

My confusion is, footprinter defines the physical footprint. core knows the component’s electrical meaning. 
Polarity instructions belong in core because the same footprint can hold components with different polarity requirements.

## Rishabh — 2026-10-27T16:12:53.387000+00:00

Also, when I was updating footprinter with my fix. I saw duplicate symbols

## Seve — 2026-10-27T16:13:26.611000+00:00

so core sometimes "injects things" into footprinter strings. I think we might need to automatically detect fabrication notes possibly

## Seve — 2026-10-27T16:13:42.609000+00:00

if you want to discuss in voice i'm around

## Seve — 2026-10-27T16:13:46.117000+00:00

idk

## Seve — 2026-10-27T16:13:57.698000+00:00

you have a good point

## Seve — 2026-10-27T16:14:10.623000+00:00

but i also think footprints can come with fabrication notes

## Seve — 2026-10-27T16:14:15.020000+00:00

and changing footprints in core

## Rishabh — 2026-10-27T16:32:10.780000+00:00

joining