# contributor·Active
shibo - @Krishna regarding https://github.com/t...
mention regarding https://github.com/tscircuit/altium to circuit json/pull/52
Started by shiboSep 19, 20267 messages
← Back to community index
Discussion
Last active 1 hour ago · plain textshibooriginal post
<@1362486994583687421> regarding https://github.com/tscircuit/altium-to-circuit-json/pull/52
shibo
why does your PR have no svg snapshot changes after you added is_hidden?
Krishna
I tried adding is_hidden to circuit-json and tried to use it on atium-tocircuit-json (i taught this was correct approach)
pr #52 now handles nameon/commenton directly in altium-to-circuit-json
shibo
your issue was that is_hidden is not supported by any other repo, for example circuit-to-svg won't hide the silkscreen
Krishna
yes
shibo
and I doubt we should delete the silkscreen if it's hidden
shibo
if you want to change circuit-json please give your proposal to Seve
Want to add to the conversation?
Reply in Discord so your notes stay connected to the source.