shibo - @Krishna regarding https://github.com/t...

why does your PR have no svg snapshot changes after you added is_hidden?

I tried adding is_hidden to circuit-json and tried to use it on atium-tocircuit-json (i taught this was correct approach) pr #52 now handles nameon/commenton directly in altium-to-circuit-json

your issue was that is_hidden is not supported by any other repo, for example circuit-to-svg won't hide the silkscreen

yes

and I doubt we should delete the silkscreen if it's hidden

if you want to change circuit-json please give your proposal to Seve

Ok, I won’t remove the hidden silkscreen because that would lose data. <@757706909351411845> I’d like to add is_hidden?: boolean to Circuit JSON: (https://github.com/tscircuit/circuit-json/pull/807) If that approach is correct, I will update circuit-to-svg to skip hidden text when rendering. and then I will update altium-to-circuit-json#52 to map with altiums NAMEON and COMMENTON values to is_hidden and regenerate the svg snapshots.

<@757706909351411845> Could you please confirm whether this is the right approach?

<:warning:892823499205406760> Please avoid using excessive mentions, as it creates unnecessary notifications and disrupts others — use mentions only when truly needed to keep the discussion focused and respectful; repeated misuse may lead to moderation action.