# shibo - @Krishna regarding https://github.com/t...

Channel: #contributor
Source: https://discord.com/channels/1233487248129921135/1550953886028796057
Started: 2026-09-19T19:37:02.815000+00:00
Last activity: 2026-09-20T06:22:46.946000+00:00

## shibo — 2026-09-19T19:37:01.759000+00:00

<@1362486994583687421> regarding https://github.com/tscircuit/altium-to-circuit-json/pull/52

## shibo — 2026-09-19T19:37:19.958000+00:00

why does your PR have no svg snapshot changes after you added is_hidden?

## Krishna — 2026-09-19T20:27:21.501000+00:00

I tried adding is_hidden to circuit-json and tried to use it on atium-tocircuit-json (i taught this was correct approach) 
pr #52 now handles nameon/commenton directly in altium-to-circuit-json

## shibo — 2026-09-19T20:28:50.708000+00:00

your issue was that is_hidden is not supported by any other repo, for example circuit-to-svg won't hide the silkscreen

## Krishna — 2026-09-19T20:29:06.299000+00:00

yes

## shibo — 2026-09-19T20:29:11.843000+00:00

and I doubt we should delete the silkscreen if it's hidden

## shibo — 2026-09-19T20:29:27.823000+00:00

if you want to change circuit-json please give your proposal to Seve

## Krishna — 2026-09-20T05:40:03.416000+00:00

Ok, I won’t remove the hidden silkscreen because that would lose data.
<@757706909351411845>  I’d like to add is_hidden?: boolean to Circuit JSON: (https://github.com/tscircuit/circuit-json/pull/807)
If that approach is correct, I will update circuit-to-svg to skip hidden text when rendering. and then I will update altium-to-circuit-json#52 to map with altiums NAMEON and COMMENTON values to is_hidden and regenerate the svg snapshots.

## Krishna — 2026-09-20T06:22:45.575000+00:00

<@757706909351411845> Could you please confirm whether this is the right approach?

## Sapphire — 2026-09-20T06:22:46.946000+00:00

<:warning:892823499205406760> Please avoid using excessive mentions, as it creates unnecessary notifications and disrupts others — use mentions only when truly needed to keep the discussion focused and respectful; repeated misuse may lead to moderation action.