← Back to community index
# contributor·Active

Abse - @Seve

mention

Started by AbseAug 23, 202682 messages

Discussion

Last active 3 days ago · plain text
Abseoriginal post
<@757706909351411845>
Abse
The tscircuit update is blocked because its dependency-sync script mistakes Core’s internally bundled winding solver for a dependency that tscircuit must install directly. Adding the solver to the script’s exclusion list should unblock the update and allow the new Core, Eval, and autorouter versions to propagate.
Abse
https://github.com/tscircuit/tscircuit/actions/runs/32660838958
Seve
yea it needs to be added
Seve
but not to core's exclusion
Seve
you just add it as a tscircuit dep
Seve
very easy/common fix
Seve
you just add it as a dependency to tscircuit/tscircuit
Seve
no propagation needed
Abse
Ok
Abse
<@757706909351411845> https://github.com/tscircuit/tscircuit/pull/4608
Seve
oh you can't use github deps there
Seve
so then we have to bundle in core
Seve
or wherever
Seve
what you originally said
Seve
or we release it as a package but idk
Seve
it's a lot harder to release packages now
Seve
so maybe we just bundle with core
Abse
Ok
Abse
its already bundled we just need to ignore it https://github.com/tscircuit/tscircuit/pull/4608
Abse
<@757706909351411845>
Abse
<@757706909351411845> https://github.com/tscircuit/schematic-trace-solver/pull/973
Abse
can you check this again
Seve
yep
Seve
ah sorry
Seve
you really have to split this in two
Seve
i can't see what's fixed
Seve
so the first pr needs to update the repro to the right schematic snapshot
Seve
i literally just can't tell if it's better or worse
Abse
<@757706909351411845> should be clean now
Seve
ehhh i disagree with your solution, now that i can see it
Seve
where is the reference
Abse
<@757706909351411845>
Abse
idk ur call
Abse
<@757706909351411845> <@809856037376491570> can I get another review on this https://github.com/tscircuit/ti/pull/132
Abse
Wdyt?
Abse
<@757706909351411845> wdyt should we follow the ref?
Seve
hhmm
Seve
i don't feel strongly about this case tbh
Seve
the net labels are annoying though
Abse
Should we keep the routing as it is now?
Abse
Wdym?
Abse
Like the auto generated ones?
Seve
the L, R etc.
Seve
i think we should inline or remove those
Abse
<@757706909351411845> should we keep making these examples or does TI they want to see other stuff , I watched the meeting still not sure
Seve
idk why they're showing up
Seve
idk
Seve
we need M0 and M33 boards i guess, it's hard to decide what to do exactly
Seve
we don't want the schematics to look bad
Seve
we also need AllegroX export
Seve
idk man very difficult choices- i do think they will care a lot about the schematic when it's actually "go time" to integrate, we still haven't gotten in front of the actual product team
Abse
<@757706909351411845> https://github.com/tscircuit/schematic-trace-solver/pull/973/changes#diff-60f4dfa882b09810a2721a841cdf06680ecf388b78ec594c5942130110dedffb
Abse
revmoed the net lables not sure if we are going to merge this or not ?
Seve
i don't think we should merge it- i'm actually confused what you're doing with that pr
Seve
it's a core issue if core is asking for the net labels to be provided
Seve
removing it from the test doesn't make it so that core does the net labels better
Seve
i don't think it's a clear win from a schematic perspective
Abse
Im only trying to make the routing as the ref
Seve
there are other solutions that would improve what we're doing but disagree with ti
Seve
yea i don't think the ref is perfect on that one
Abse
can we merge the sch like this ?
Seve
why would we?
Abse
like this
Abse
the current routing I mean
Abse
not this pr
Seve
yea the ti pr could be merged (is that what you're asking?)
Abse
One sec
Abse
<@757706909351411845> <@809856037376491570> https://github.com/tscircuit/ti/pull/134
Abse
this too https://github.com/tscircuit/ti/pull/116
Abse
https://github.com/tscircuit/ti/pull/133
Abse
<@757706909351411845> https://github.com/tscircuit/tscircuit-autorouter/pull/2281
Abse
can you review this ty
Abse
this too https://github.com/tscircuit/ti/pull/134
Abse
<@757706909351411845>
Abse
<@757706909351411845> <@809856037376491570> https://github.com/tscircuit/core/pull/3522
Abse
<@757706909351411845> <@809856037376491570> for this pr do we only want to preserve the gnd symbols ? like is it ok to replace the GND net lables with on trace label
Abse
I can see that we want to keep the generated gnd symbol but what about the normal gnd labels pointed by the red arrows
Rishabh
I think on trace label replaced with the netlabel is okay, but yes the GND symbol should be there
Abse
sg

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗