Seve - @Abse do you want to chat on voice

we should populate it with FEMALE pinheaders

that might be complex depending on how it's defined 😬

yeah I'm going with a female didn't pick a part number yet

cool

btw jlcsearch has a dedicated page for JST connectors https://jlcsearch.tscircuit.com/jst_connectors/list

let's use 2mm pitch it's wayyyyyy more common

maybe this https://jlcpcb.com/partdetail/BM02B-PASS-TFT(LF)(SN)/C265372

https://jlcsearch.tscircuit.com/jst_connectors/list?package=SMD%2CP%3D2mm&num_pins=2&pitch_mm=2

https://jlcpcb.com/partdetail/SM02B-PASS-TBT(LF)(SN)/C265417

<@757706909351411845> http://github.com/tscircuit/cli/pull/3485

https://www.lcdwiki.com/2.8inch_SPI_Module_ILI9341_SKU:MSP2807

yea seems solid

<@757706909351411845> I think we are done 😮‍💨

https://tscircuit.com/editor?package_id=bdff6d37-760b-4aff-8ab1-fae5bc833e32&file_path=index.circuit.tsx

plz review, mouting holes will be added now

Afk 😭

haha no worries let me know what you thing when you see it I will order it in the morning is that ok ?

can we still make it ?

Yea i think so

Yea probably

I added long buttons and long 5mm long power switch

If u screenshot it i can at least confirm some stuff if u want to order

Up to you

3d and pcb can help me do a quicj check

Doesnt load on my phone

Oh

No mounting holes for the board?

this is pre holes

Oh

pushing rn

Looks good

the power circuit is crazy

lol

Hmm

One possible concern is the button height vs screen height

We can make it work either way but the buttons should stick out beyond the screen

in theory, when usb c plugged should not drain the bat etc

In theory haha

You have to have isolation

Hopefully the ai did that

.

If the schematic isnt clean impossible to review it as an EE

I tried to clean it not sure if I don't know how or it does not work ?

Is button height >12mm to be outside screen

tried to use sections no schx/y etc

the datasheet is dumb showing the short version let me look

Put name prop on all traces and use schematic sections, you CAN use schX/schY

In fact its better to provide schX and schY to incrementally improve

Haha yea a bit tricky

button height is 10 mm

should I look for 15 ?

I guess so

Otherwise the case has to have the screen kind of pop out ig

I will export to STEP and try a design tonight?

https://tscircuit.com/editor?package_id=bdff6d37-760b-4aff-8ab1-fae5bc833e32&file_path=index.circuit.tsx

15 mm pushbuttons and mounting holes

heading to bed

not sure we can clean sch alot

Cc <@1079361271687807026> <@436098556974333952> this has to be fixed!!!! Cant review this- it is a bug!!!!

Will review now and do quick model

<@398467566588264449> PCB looks good but really wish i could review schematic- we definitely need to get this label issue resolved ASAP!

might take a look if nobody else is

sry I can't it's 2 AM here and I'm exhausted

ur good i meant mustafa or sangit

step model btw

wow this STEP file has a lot of bugs

<@398467566588264449> what's the JST connector in the center of the board for?

did a very basic case, it was hard to do without the step but i think it should fit!

Speaker will connect there and be mounted on the Gameboy case right?

ohhh

yea i have to have a place for the speaker

does it have volume control via a potetiometer btw?

forgot about it completely

I will try to add a potetiometer quickly

if you want to be real crazy you could put a right angle potentiometer (a small one) on the side- then volume could be adjusted by the user

can't review schematic until that other bug is fixed- up to you if you want to order before we do a proper schematic review

That what I was thinking about haha

I will put the volume control on the left

<@1079361271687807026> might wake up soon and be able to help with the trace name fix, which i think is a pretty big deal (good find on your part- will probably effect ti)

Yeah I can wait

name on trace is not working?

It should create a short label according to name

it's not working for the subcircuits, check out his circuit

https://tscircuit.com/editor?package_id=bdff6d37-760b-4aff-8ab1-fae5bc833e32&file_path=index.circuit.tsx

<@398467566588264449> https://github.com/tscircuit/core/pull/2538

Lgtm but you have test failing

<@398467566588264449> looks much cleaner now, but you have some bad schX/schY coordinates in the subcircuits. You need to fix that.

Will fix them ty

<@400684445054795796> I don't understand, when I generate the srj from core and run it in autoruoter it works but it still fail on tscirucit.com and on the cli when trying to route ?

version issue ?? the core is not on latest auto router

https://github.com/tscircuit/core/pull/2557/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

I'm losing my mind

<@398467566588264449> status?

is their any other problem <@398467566588264449> with this; you said something is wrong do you also mean this issue or something else

same issue yeah