HarsH - Hey maintainers! ๐ Sharing my open PRs...
Hey maintainers! ๐ Sharing my open PRs for review whenever you have time: 1. runframe 6024: fix fabrication ZIP Gerber layout to match CLI root (4/4 CI green) https://github.com/tscircuit/runframe/pull/6024 2. core 5053: fix preserve oriented symbolName and apply schRotation (18
Hey maintainers! ๐ Sharing my open PRs for review whenever you have time:
1. runframe #6024: fix fabrication ZIP Gerber layout to match CLI root (4/4 CI green)
https://github.com/tscircuit/runframe/pull/6024
2. core #5053: fix preserve oriented symbolName and apply schRotation (18/18 CI green)
https://github.com/tscircuit/core/pull/5053
3. core #5054 & #5055: repro test + fix for group keepouts in pcbPack (18/18 CI green)
https://github.com/tscircuit/core/pull/5054
https://github.com/tscircuit/core/pull/5055
4. image-utils #59 & #60: repro test + RFC 9110 media-type normalization (2/2 CI green)
https://github.com/tscircuit/image-utils/pull/59
https://github.com/tscircuit/image-utils/pull/60
5. contribution-tracker #382: map Discord ID 757655182002749644
https://github.com/tscircuit/contribution-tracker/pull/382
All PRs have isolated tests, zero merge conflicts, and 100% green CI. Thanks!
Seve
for core PRs especially you should try to have a good visual repro PR then stack a fix PR such that the diff is clear
Seve
for some of the PRs, you need to specify the motivation, in particular it's unclear to me that https://github.com/tscircuit/image-utils/issues/58 is credible
Seve
the motivation should generally be from a real problem you or a user faced while building a real board with intent to order
Want to add to the conversation?
Reply in Discord so your notes stay connected to the source.