← Back to community index
# contributor·Active

Ray - These 2 PRs from me are still sitting at ...

These 2 PRs from me are still sitting at the 2 week mark. I confirmed the issue described still exists, and updated them so they are once again green. 596: https://github.com/tscircuit/circuit json to kicad/pull/596 552: https://github.com/tscircuit/circuit json to kicad/pull/552

Started by RayOct 15, 20266 messages

Discussion

Last active 3 days ago · plain text
Rayoriginal post
These 2 PRs from me are still sitting at the 2 week mark. I confirmed the issue described still exists, and updated them so they are once again green. #596: https://github.com/tscircuit/circuit-json-to-kicad/pull/596 #552: https://github.com/tscircuit/circuit-json-to-kicad/pull/552
Seve
thanks for pinging, RE:552 https://github.com/tscircuit/circuit-json-to-kicad/pull/552 IIUC this converts TSX inline net labels into global net labels- i think we need to be using local net labels (kicad's equivalent to inline net labels?) CC <@1079361271687807026> <@809856037376491570> let's try to figure this out (take a look at the issue), which is valid, the PR i'm not sure about because of the inline net labels converted to global vs local net labels (local net labels are essentially inline net labels) Ray's fix in #552 is an improvement over the current state but may not be correct w/ global vs local labels (<@332593194212524042> if you think i've got this wrong please lmk, otherw
Seve
*wise will attempt to put the local net label approach into practice in a derivative PR)
Seve
also fwiw AI may just tell me that i'm wrong at some point in this process
Ray
This was all Claude from issues during board generation that are still present today. Feel free to solve however you wish 🙂
Mustafa7
<@809856037376491570> https://github.com/tscircuit/circuit-json-to-kicad/pull/658

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗