@Rishabh is this kind of usb-c port

<@809856037376491570> please review: https://tscircuit.com/ShiboSoftwareDev/nema8-20mm-dual-usbc-stepper-controller#3d

idk if i mentioned this last time but you need to be consistent w/ the usb ports and exit them all upward i think, otherwise it is difficult to integrate and looks weird

so they should all face up

then you should use the extra space to have four mounting holes

<@809856037376491570> https://tscircuit.com/ShiboSoftwareDev/nema8-20mm-dual-usbc-stepper-controller#3d

use standard schematics for usb

I don't see silkscreen for PWR and DATA

make sure the current carrying wire is going through the outer layers

why such a big box?

<@809856037376491570> please re review

I still see the usbc not using the standard schematic

You didn't change the power wires to outer layers

what should I re-review?

As the outer layers are cramped I moved the higher current routes and kept the lower current ones

I don't know what the standard schematic is, I tried to copy the one you had on one of your boards

<connector standard="usb_c" /> forces the default schematic- there should be a warning and AI should be able to know how to correct it from the message but there's currently not

<@757706909351411845> can you please review? https://tscircuit.com/ShiboSoftwareDev/nema8-20mm-dual-usbc-stepper-controller#3d

where is the data mcu?

that is a pd mcu iiuc

yeah, it’s a PD MCU, but it also supports USB data and can run the motor control firmware. it's called CH32X035 we use it for both jobs, so there isn’t a separate data MCU

ok so how are you controlling both USD PD and USB DATA with a single mcu?

(it's not possible)

also unless it has an adc you don't have current sense

the chip has separate hardware for USB data and USB-PD the driver chip senses and regulates motor current internally but the relevant signal is not connected to the MCU

Fake engineering

This board does not have usb pd

(Negotiating pd out of data does not count, of course, the whole point of data is to avoid PD)

we aren’t negotiating PD through the DATA port, PD negotiation happens on the separate PWR port through its CC pins

I think you are correct!

I was told DP and DM are required for PD by an eng and i did not question it

Do you have an adc with current sense

That is very clever <@778624824875941908> i have learned something important

You should also do the assembly

the driver chip senses current but i didn't connect the related signal to the mcu

Interesting

You are using the TMC driver, which is a very fancy driver

So it might be OK

wdym? adding the 3d model of the motor and connecting the board to it

Yeah, it’s good for verifying that everything is gonna fit together

Look up assembly.motor in the docs

Let’s have Rishabh review as well, but after that, I think we can probably order

<@809856037376491570> <@757706909351411845> the led would have to face upwards right? away from the motor