@Seve https://tscircuit.com/

It has only one usbc for both pd and programming rp2040, AI did not add two coz of the board space. Let me know if those needs to be separate usbc

yes it is a requirement

this requires soldering to set up as well, i want to be able to plug in a battery and motor

it is a requirement to have a pd port because otherwise the liklihood of damaging a supply is high

Move the jst to the edge, don't place it at the center

i'm also wondering what battery is plugged into this, because i think lipos are more than 2 wire in many cases (i don't remember what the third wire is)

gotcha ok so for single cell it's two wires 👍

<@757706909351411845> https://tscircuit.com/MustafaMulla29/rp2040-bldc-motor-controller-new#3d Fixed! Added separate usbc for data and pd. Can you review and let know the issues you find.

the usbc and usb pd should be on the same side and you still haven't addressed the things i mentioned last time

How do i connect the motor (i do not want to solder, already mentioned) How do i connect the battery?

also Rishabh told you to move the JST to the edge but you didn't switch the component to be edge facing

this is NOT ready for review, you haven't thought it through, you need to have more product intuition on this- think about how the product will be used and address these things before i need to mention them!

Which USB is PWR vs DATA? They aren't clearly marked!

the schematic is also a bit silly, make sure to look at references for these chips, they will not look like this (there is no schematic created by a human on earth that looks like this!!!!)

non-standard USB-C footprint, also issues with it

each motor connection is a separate component (a single plated hole = single component?)

all said that page is maybe the cleanest

but you can use schematicbox for that rather than 3 separate components

3S cell protection- i thought you were using single cell? Am I confused? What battery does this go with? (I shouldn't need to ask!!!)

annoyed that this isn't near the battery connectors, also why does the battery connect in two places?

https://tscircuit.com/MustafaMulla29/rp2040-bldc-motor-controller-new#files <@757706909351411845> review please! The schematic-analysis reports a lot of false positives or wrong suggestions, am working on fixing them. The battery is "one 3S, 2200 mAh LiPo battery pack" ```ONE 3S LiPo battery ├── Thick red/black wires → XT60 plug → J13 └── Four thin wires → small JST-XH plug → J15``` I have improved the schematic to follow the references.

i have to keep telling people this, but generally you _never mix vertical and side connectors on the same board_, you have both vertical and side connectors, just go with the side connectors (those are usually more stable and available), triple check that everything plugs in!!!

i'm looking at your banana plug connector and i'm not sure it's right, triple check these things, if they don't match it'll be a waste of money!

i think your motor connector is wrong as well

yea the schematic still needs a lot of work to be readable but it's a good one to chase to get all the issues. One of the big issues is just really long "schematic subcircuits" like this one. Ideally the "path to ground" or "path to power" is all visible from the pin

<@757706909351411845> does this sound good?

no absolutely not

the entire thing i'm avoiding is adapter wires

getting annoyed about this, you should now do a full assembly

i.e. you need to create the entire system in 3d in tscircuit assembly components with <assembly.cable /> etc. because it seems like you cannot visualize the system

you may need to add support for the particular cables you're using. For the model, you will want to probably create this via e.g. Opus and build123d

https://cleanshot.com/share/3tDGd23y

https://tscircuit.com/MustafaMulla29/rp2040-bldc-motor-controller-new#files

<@757706909351411845>

cannot see assembly on 3d viewer, this is from local server. Do we have to create a new package integrating the assembly?

is tscircuit up to date

btw let me know when you're asking for review, i know you sent a link there but based on the pin headers and empty space on the board i'm guessing you're not ready for review yet

yes

it was 70x65 before but after adding sockets it became 80x95 thats why there is some empty space left

those sockets are big

Ill see until where i can decrease the size

i would investigate that bug

don't worry about decreasing the size yet

you need to get rid of all these pin headers and get your board ready

why do you have a million pin headers

<@757706909351411845> some of the headers were for these, we have to put these on pcb itself right?

oof

yea you need to include all that in your assembly and source it all

if you don't need it don't put it on

Removed pin headers and shinked it down by 5mm https://tscircuit.com/MustafaMulla29/rp2040-bldc-motor-controller-new#files

Let me know if any issues, headed to bed. I'll fix in morning

your banana plugs are facing the wrong way i think

you need a power switch

yea try to complete a full assembly

Wdym? You only said to do motor assembly right?

just make sure everything needed to run the motor is connected, if there's something needed to run the motor, make sure it's added

<@757706909351411845> The board includes USB-PD charging and battery protection, each with a separate battery-temperature input. Should we keep two external temperature probes, or would you prefer a simpler temperature-sensing arrangement?

i'm not sure

what's the reference design do?

reference design doesnt have battery

why do we need a battery?

i really just want to control a motor with USB PD and USB DATA

You recommended me to add battery right

i think there is a lot of stuff added

usb pd charges the battery

i'm not designing the product

i said that a battery can help with current draw

you're the product designer but i think we probably don't want the battery

if usb-pd can power it

especially because the board is huge right now

ok ill remove battery

ask ai, understand the product, redesign as needed, you have to make this product SELL which means it's gotta be good

i don't think people are going to want to buy a battery and we wouldn't package a battery i think

don't just do random stuff that i'm saying, i'm here to help not design the product

you should be able to answer WHY for every design decision

https://tscircuit.com/MustafaMulla29/rp2040-bldc-motor-controller-new#files Please review when you get time, am probably asking for too many reviews! Build is running still not completed yet. THis includes the motor adapter etc assembly.

The power traces should be on the outer layers

I see via stitching happening on your board, some of them look uncessary

Add knockout silkscreen to these, confusing which one is data and which is pwr

I think get a review from AI first, I made ai review this and it gives a lot of placement issue and the width of traces