← Back to community index
# support·Active

Ray - bumping this as important and serious, se...

bumping this as important and serious, see latest comments: https://github.com/tscircuit/circuit json to kicad/issues/579

Started by RaySep 23, 202616 messages

Discussion

Last active 2 months ago · plain text
Rayoriginal post
bumping this as important and serious, see latest comments: https://github.com/tscircuit/circuit-json-to-kicad/issues/579
Seve
<@1079361271687807026>
Ray
and apparently 3 contributors have already opened fixes for #579 (PRs #580, #581 and #587).
Seve
Likely Ai spammers, we dont review them. They dont know what theyve written, often no repro
Seve
Rushabh has a legit pr thi
Seve
https://github.com/tscircuit/circuit-json-to-kicad/pull/581/files
Seve
<@1079361271687807026> <@452450065941004289> im afk plz review/figure out
Seve
Idk if rushabhs pr fixes it because there isnt a repro in that pr (?)
Seve
Make sure rays issue is fixed
! Rushabh | Linux Shill
the pr got missed in the review channel Previously, the converter numbered symbol pins according to the order in which the symbol library returned them. That order might not match the component’s real pin numbers. The change makes the converter prefer a numeric pin label supplied by the circuit i believe it is correct fix <@1079361271687807026> can yo take a look, i will add a repro if you want
Ray
I guess I had my own PR, you can compare: https://github.com/tscircuit/circuit-json-to-kicad/pull/596
Ray
but it also has failures so ai slop meh 🙂
Mustafa7
ok lets merge the repro first if you want?
Mustafa7
https://github.com/tscircuit/circuit-json-to-kicad/pull/581/files <@452450065941004289> we merged the repro right, so can you update the pr with regarding the repro
Mustafa7
<@452450065941004289> merge this if you feel you have verified my review comment.
Mustafa7
<@452450065941004289> you didn't merge this yet? We should not delay user issues. Merge it if you feel you have verified the review changes

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗