← Back to community index
# contributor·Active

Seve - NOTE: We're now exiting 0 if there are A...

NOTE: We're now exiting 0 if there are ANY circuit json errors. This might mess up AI, please watch out to see if AI looks like it's getting messed up as a result

Started by SeveSep 11, 20267 messages

Discussion

Last active 3 hours ago · plain text
Seveoriginal post
NOTE: We're now exiting 0 if there are ANY circuit json errors. This might mess up AI, please watch out to see if AI looks like it's getting messed up as a result
shibo
is this because we don't want AI to work on top of failing boards?
Seve
<@332593194212524042> requested it, it's more conventional behavior when there's a build error
Ray
astra complained on my behalf 🙂
Ray
So if anything that was something that tripped up AI and AI requested the behaviour change
foobar
Isn’t exiting nonzero on error more traditional behavior?
Seve
Yes, i think since we’re using the term “error” that is appropriate We didn’t do it originally because we didnt consider DRCs to be a “build failure”, but now that we are generally drc-free it makes more sense

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗