tscircuit community
← Back to community index
# contributor·Active

Mustafa7 - @Abse currently footprinter supports...

mention currently footprinter supports params like w h for passives but there are courtyards being generated for custom footprinter strings for passives and also easyeda imports(string like res p4.6599mm pw2.91mm ph2.9106mm) doesnt describe the w/h in the passives strings. So is

Started by Mustafa7Aug 21, 202614 messages

Discussion

Last active 14 days ago · plain text
Mustafa7original post
<@398467566588264449> currently footprinter supports params like `w` `h` for passives but there are courtyards being generated for custom footprinter strings for passives and also easyeda imports(string like `res_p4.6599mm_pw2.91mm_ph2.9106mm`) doesnt describe the w/h in the passives strings. So is that an intendted behaviour or is that an issue. if its an issue then there are two repos needs fixing, 1. tscircuit/footprinter should be able to produce courtyards from w/h params 2. circuit-json-to-footprinter should describe strings like `res_p4.6599mm_pw2.91mm_ph2.9106mm_w10mm_h5mm` from the easyeda data.
Abse
I'm not sure if all footprints need w and h?
Abse
Yes all footprints need to generate courtyard
Abse
How the footprints that has courtyard is doing it?
Mustafa7
it uses direct footprint: ```<resistor name="R_PD_GATE_DRIVE" resistance="22k" footprint="0603" pcbX={-27.5} pcbY={26.7} pcbRotation={90} schX={10} schY={4} schSheetName={sheets.powerInput} schSectionName={sections.usbPd} />```
Mustafa7
for custom footprinter strings for passives there are no couryards being generated
Mustafa7
this is the one that does not have a courtyard from the image: ```export const B5819W_SL = (props: DiodeProps) => { const { name = "D1", ...restProps } = props return ( <diode name={name} pinLabels={pinLabels} supplierPartNumbers={{ "jlcpcb": [ "C8598" ] }} manufacturerPartNumber="B5819W SL" footprint="res_p3.4mm_pw1.2mm_ph0.95mm" cadModel={{ objUrl: "https://modelcdn.tscircuit.com/easyeda_models/assets/C8598.obj?uuid=e9d505c99b6c436aaf827a29c5ba4f84", stepUrl: "https://modelcdn.tscircuit.com/easyeda_models/assets/C8598.step?uuid=e9d505c99b6c436aaf827a29c5ba4f84", pcbRotationOffset: 0, modelOriginPosition: { x: 0, y: 0.000012699999999199463, z: -0.6 }, }} {...restProps} /> ) }```
Abse
Wr can just calculate the courtyard internally no need to add w and h for all right?
Abse
In cases like this <@757706909351411845> should see this too footprinter should follow a clear API design
Mustafa7
but wouldnt that be a hack to guess courtyards from the pads width/height?
Mustafa7
Body will be different from pads right
Anas
Seve and I noticed that too; we did try to do some PRs, like extracting the courtyard size from the silkscreen CC: <@757706909351411845>
Mustafa7
https://github.com/tscircuit/footprinter/pull/818 https://github.com/tscircuit/circuit-json-to-footprinter/pull/105 Codex did something

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗