← Back to community index
# contributor·Active

Mustafa7 - @0hmx fanout tests in core main bran...

mention fanout tests in core main branch are failing, do you have any idea what caused it? https://github.com/tscircuit/core/actions/runs/31172218425/job/92846325200?pr=3036

Started by Mustafa7Aug 7, 202621 messages

Discussion

Last active 28 days ago · plain text
Mustafa7original post
<@400684445054795796> fanout tests in core main branch are failing, do you have any idea what caused it? https://github.com/tscircuit/core/actions/runs/31172218425/job/92846325200?pr=3036
0hmx
checking
0hmx
Ah, something happened, but I’m not sure why. Core not showing this test failure, which occurred after the PR was merged. Merging the PR triggered another test run, but it ran against the PR branch instead of `main`. That’s very confusing and seems like a separate bug we should investigate later.
Mustafa7
Am fixing it, ig its a new policy issue
Mustafa7
Yea its related to decoupling caps
0hmx
Its on us but we also need to fix core it hiding falling test if they are triggered after merge. like in this case.
Mustafa7
isnt that a github ci issue?
Mustafa7
Like running after merged
0hmx
Shared an attachment
Mustafa7
oh ok so its showing green checks very early right?
Mustafa7
https://github.com/tscircuit/core/pull/3038 you can see here it just completed all workflows in just 3 mins?
Mustafa7
How?
Mustafa7
it took like one min to run tests?
0hmx
this is diffrent issue tho i think idk
0hmx
<@757706909351411845>
Mustafa7
```Old behavior: Place components → route everything → tests pass New behavior: Recognize capacitor as decoupling ↓ Apply 1 mm limit ↓ Check placement before routing ↓ Endpoints are 2.68 mm / 7.27 mm apart ↓ Skip the entire subcircuit router ↓ Zero PCB traces → tests fail``` This was the main issue for failing the breakout tests
Mustafa7
in core
Mustafa7
https://github.com/tscircuit/core/pull/3038 i think we should merge it right?
Mustafa7
<@809856037376491570>
0hmx
The failure appear on `main` because GitHub Actions was experiencing downtime. As a result, the workflows were not triggered on time, causing a silent CI failure. Previously, all 15 test jobs were running now for the last 3 comments they did not even run. I think its fixed now again. haa shity downtime. the missed workflow runs did run after some time in which we caught the new test fails. <@1079361271687807026>
Mustafa7
Ohh didn't even notice

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗