← Back to community index
# support·Active

astrimid - Is there any reason favorites featur...

Is there any reason favorites feature commented out but not removed? https://github.com/tscircuit/runframe/pull/1470

Started by astrimidAug 4, 20262 messages

Discussion

Last active last month · plain text
astrimid
How I founds it: - I was fixing biome lint issues - Tests still pass down pinned files props related to the feature above - Code assistant suggested adding the props back to the relevant react component instead of fixing the test to remove them. So, AI was confused about the feature: - if feature got removed, why tests still have it? - the feature commented out, so the interface is not used in implementation The logical course of action is to: - either remove it completely and fix the tests to remove - or uncomment and fix the feature

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗