← Back to community index
# contributor·Active

Seve - @Abse subcircuit caching should be much ...

mention subcircuit caching should be much better now

Started by SeveAug 3, 202649 messages

Discussion

Last active 21 days ago · plain text
Seveoriginal post
<@398467566588264449> subcircuit caching should be much better now
Abse
<@757706909351411845> https://github.com/tscircuit/footprinter/pull/769
Seve
we should definitely have a snapshot for this stuff with the footprint we're targeting
Seve
i wouldn't have approved it because idk if you targeted a non-QFN component
Seve
how do i know there's not a better function name
Seve
the "lr" convention is going to be pervasive if we use it- can you share the chip you were attempting to capture
Abse
ok one sec
Abse
<@757706909351411845> C128396
Seve
ok let's see how it goes
Seve
you should always introduce the full name in addition to the alias btw
Abse
https://github.com/tscircuit/footprinter/pull/770
Abse
<@757706909351411845> hay **Repros:** [PR #3018](https://github.com/tscircuit/core/pull/3018) includes a minimal case where a parent trace crosses preserved different-net child copper, and a Game Boy-like case where parent-to-MCU routing exhausts the autorouter iteration limit. **Fix:** [PR #3044](https://github.com/tscircuit/core/pull/3044) routes the MCU through a virtual breakout, preserves breakout-point identity across routing phases, and routes explicitly breakout-owned nets early. The large board now routes without physical headers and passes DRC.
Abse
can you validate if this is a real bug in the breakout and a fix
Abse
also check these Here’s a brief Discord-ready update: **JLC5000 footprint improvements** All Footprinter PRs have passing CI and produce 99%+ IoU: - **C2883760 – Staggered SMD pin header:** Discovery ignored the vertical row pitch. Added staggered-row detection and measured `py`. **87.20% → 99.997%** https://github.com/tscircuit/circuit-json-to-footprinter/pull/85 - **C151520 – BFP650 SOT-343:** Uses a wider, inward-shifted emitter pad that standard SOT-343 cannot represent. Added a specific BFP650 variant without changing the standard footprint. **89.13% → 99.966%** https://github.com/tscircuit/footprinter/pull/771 - **C22461789 – LED3510:** Four inline LED pads with wider outer contacts were incorrectly matched as FPC. Added an explicit LED3510 footprint. **89.08% → 99.989%** https://github.com/tscircuit/footprinter/pull/772 - **C78322 – SMD potentiometer:** Existing potentiometer support was through-hole only. Added an SMD potentiometer variant with a wider center pad. **88.34% → 99.998%** https://github.com/tscircuit/footprinter/pull/773 - **C2827688 – SOT-143:** Pin 1 is wider and shifted inward, which symmetric families cannot reproduce. Added an explicit SOT-143 footprint. **88.16% → 100%** https://github.com/tscircuit/footprinter/pull/774 - **C29718 – 0603x4 resistor array:** The end terminals are wider than the inner terminals. Added configurable column pitch and outer-pad height to the existing family. **87.39% → 99.973%** https://github.com/tscircuit/footprinter/pull/775
Abse
- **C225714 – G5NB relay:** The sparse four-hole layout has two different hole sizes and cannot be modeled as a pin grid. Added a specific G5NB relay footprint. **87.27% → 99.993%** https://github.com/tscircuit/footprinter/pull/776 - **C2979263 – TOLL-8:** Existing discovery approximated the large drain copper as an offset thermal pad. Added a proper TOLL-8 footprint with leads, bridge, and drain pad. **86.22% → 99.997%** https://github.com/tscircuit/footprinter/pull/777 - **C3130 – Fuse clip:** Uses two rotated plated slots, but existing candidates only supported circular holes. Added a slotted fuse-clip footprint. **86.14% → 100%** https://github.com/tscircuit/footprinter/pull/778 - **C35556 – UFQFPN-20:** Eight corner leads are chamfered polygons that regular QFN/LGA pads cannot reproduce. Added an explicit UFQFPN-20 footprint. **85.75% → 100%** https://github.com/tscircuit/footprinter/pull/779
Abse
<@757706909351411845> if it\s not a standard do we always try to make it using parameters on existing fps ?
Seve
ya igs
Seve
I dont think footprinter should start supporting manufacturer specific stuff
Abse
so we should reach a point where we don't want a fp string to make it and just use polygon pads or wtvr
Seve
Yea the relay one is interesting tho
Abse
<@757706909351411845> https://github.com/tscircuit/footprinter/pull/781
Abse
can u review one more time ty
Abse
<@757706909351411845>
Seve
i think we should probably accept the smtpads alias for this, also it's driving me crazy that you keep adding "centerpadwidth", which is objectively incorrect
Seve
smdpads4_centerpadwidth4 (what is the center pad now?)
Seve
bad design!
Seve
actually you know what
Seve
it's fine
Seve
we don't normally throw errors in footprints
Seve
but it's fine
Seve
i guess it is how a human might describe it
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3081
Seve
Nice find
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3087
Abse
https://github.com/tscircuit/core/pull/3121
Seve
nice
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3123
Abse
https://github.com/tscircuit/core/pull/3122
Abse
https://github.com/tscircuit/cli/pull/4150
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3198
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3198
Abse
I switched the repro for the fanout bug , looks like its an srj generation bug
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3212
Seve
Your prev repro is still valid
Seve
Missing pointToConnect iiuc
Abse
yeah will be the next fix
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3213
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3219
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/3224

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗