tscircuit community
← Back to community index
# contributor·Active

! Rushabh | Linux Shill - image.png

i saw someone made a pr for this leme check Could not find port for selector "LED.neg". Component "LED" found, but does not have pin "neg". It has 2 pins and no pinLabels (consider adding pinLabels) but it is not fixing the problem is this what ? https://github.com/tscircuit/tsci

Started by ! Rushabh | Linux ShillJul 29, 202633 messages

Discussion

Last active last month · plain text
! Rushabh | Linux Shilloriginal post
Shared an attachment
image.pngimage.png
mohan-bee
i saw someone made a pr for this leme check
! Rushabh | Linux Shill
Could not find port for selector "LED.neg". Component "LED" found, but does not have pin "neg". It has 2 pins and no pinLabels (consider adding pinLabels)
! Rushabh | Linux Shill
but it is not fixing the problem
mohan-bee
is this what ? https://github.com/tscircuit/tscircuit.com/pull/4109
! Rushabh | Linux Shill
it just used pin1 and pin2 insted
mohan-bee
hmm.
! Rushabh | Linux Shill
<@757706909351411845>
mohan-bee
maybe we can use the default LED component . instead of importing that ?
mohan-bee
hey <@452450065941004289> what is progress for the code editor ?
! Rushabh | Linux Shill
will try to debug on an iphone today
Seve
<@452450065941004289> sorry that the iphone is causing an issue, i honestly like your code editor a lot more
Seve
idk if that editor has known issues w/ iphone etc.
Seve
does it work on your device?
! Rushabh | Linux Shill
it works on my device, i tested it on samsung S25, and samsung A17, will try to fix it using my friends iphone
Seve
amazing tytyty
astrimid
Shared an attachment
image.pngimage.png
astrimid
Shared an attachment
image.pngimage.png
astrimid
vs capacitor:
image.pngimage.png
Seve
yea not completely consistent
Seve
some issues are due to symbols metadata coming in differently
astrimid
So additionalAliases somehow defines whether schematic port is added or not. additional aliases are skipped if diode or led has custom footprint or pinLabels. Only AI can get how is it supposed to work:
image.pngimage.png
astrimid
Shared an attachment
image.pngimage.png
Seve
it has a lot of tests validating the behavior, the implementation doesn't matter as much as the tests that guarantee that it has the correct contract
astrimid
Could be string to number implicit conversion:
image.pngimage.png
astrimid
Yeah, uncle bob recently said that he doesn't read AI generated code because it's the only way you can benefit from it
astrimid
sounds like using AI for the sake of using AI
astrimid
Shared an attachment
image.pngimage.png
astrimid
Schematic has ports, PCB has pins. The component only receives PCB pins, no ports. It renders only PCB and doesn't output Schematic. Test passed?
astrimid
Shared an attachment
image.pngimage.png
astrimid
Shared an attachment
image.pngimage.png
astrimid
But this means children should render before parent which breaks react model
astrimid
or we could treat chilrend as plain JSX which prevents them having their own children

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗