shibo - @Seve If I want to make changes to the ...

Either way is common!

Usually if the rfc is new, edit

<@757706909351411845> https://github.com/tscircuit/rfc/pull/11

left some comments

<@757706909351411845> I split the fix for sample 4 to two parts, I understood part 1 and make the visualization clear, part 1 fixed sample 4's static reachability issue but it doesn't pass yet, the PR increased dataset 23 DRC completion by 48% https://github.com/tscircuit/tscircuit-autorouter/pull/1799

the issue is that we failed to detect bga shapes if the component has other pads outside the bga pattern

the PR body explains further

Sg!

<@757706909351411845> fix in repair solver 03, improves DRC pass rate for the kicad dataset 24 from 0% to 20%, I noticed no regressions: https://github.com/tscircuit/tscircuit-autorouter/pull/1810

cool

nice

<@757706909351411845> new sample from OpenAI's dataset passes DRC: https://github.com/tscircuit/tscircuit-autorouter/pull/1902

repair 03 fix

<@757706909351411845> new sample pass DRC in both OpenAI and kicad datasets: https://github.com/tscircuit/tscircuit-autorouter/pull/1927

DRC rate is 25% and 30% respectively

*partner datasets 😉

yea looks great

does that mean now we pass DRC for 1/4 of all boards in the world? 😂

now I want to add a kicad dataset that has 10 of the hardest boards from kicad, just to humble myself

are kicad boards a good sample of boards used in the real world? or are the hard boards for huge companies that do advanced stuff always private?

<@757706909351411845> wdyt?

🤷

kicad isn't used as much by professional companies

Altium is more used

the TI reference designs are all altium

good to know

<@757706909351411845> repair 03 fix, new sample passes DRC: https://github.com/tscircuit/tscircuit-autorouter/pull/1937

<@757706909351411845> you said how could we know it's not just from increasing iterations, i kept only the iteration increase and nothing was fix, we also have a repro in the repair 03 pr that proves the fix

<@757706909351411845> new sample passes DRC: https://github.com/tscircuit/tscircuit-autorouter/pull/1941

<@757706909351411845> no new samples pass but tens of DRC issues are fixed: https://github.com/tscircuit/tscircuit-autorouter/pull/1968

<@757706909351411845> fixed another issue, again no new samples pass: https://github.com/tscircuit/tscircuit-autorouter/pull/1950

Nice