← Back to community index
# contributor·Active

! Rushabh | Linux Shill - hey everyone need you...

hey everyone need you thoughts on the new editor, grill me https://tscircuit 8ph40wnud tscircuit.vercel.app/editor?template=blank circuit board

Started by ! Rushabh | Linux ShillJul 18, 202678 messages

Discussion

Last active 2 months ago · plain text
! Rushabh | Linux Shilloriginal post
hey everyone need you thoughts on the new editor, grill me https://tscircuit-8ph40wnud-tscircuit.vercel.app/editor?template=blank-circuit-board
mohan-bee
nice
mohan-bee
showing names two time , maybe we can prefer only one :
! Rushabh | Linux Shill
Shared an attachment
! Rushabh | Linux Shill
they both have different purpose
mohan-bee
oh they are breadcrumbs ?
! Rushabh | Linux Shill
yeah
! Rushabh | Linux Shill
the top drop down is used in small screen
! Rushabh | Linux Shill
so ig we can remove it for large screen
! Rushabh | Linux Shill
https://github.com/tscircuit/tscircuit.com/pull/3966
! Rushabh | Linux Shill
<@&1420812538421051555> please take a look everyone, dont spare my feelings!!!
mohan-bee
actually this is missing something important .. the "format and import" !
! Rushabh | Linux Shill
yeah we are not addig it in the editor
! Rushabh | Linux Shill
it is not a editor specific featuer, we will move it to the website itself
! Rushabh | Linux Shill
where should we add the option
! Rushabh | Linux Shill
we can add format in the editor ig
mohan-bee
idk maybe somewhere here ? near the download or something ?
! Rushabh | Linux Shill
yeah
mohan-bee
let see
! Rushabh | Linux Shill
anything else
mohan-bee
this editor is super cool actually .. no laggy ! 🔥
mohan-bee
combined the search with dropdown like the vscode style ..
! Rushabh | Linux Shill
wait i have even better
techmannih
It's amazing 🙌 🔥 <@452450065941004289>
! Rushabh | Linux Shill
Shared an attachment
! Rushabh | Linux Shill
Shared an attachment
mohan-bee
But this feels like having a new filebar inside that ?
! Rushabh | Linux Shill
i followed vscode
! Rushabh | Linux Shill
Shared an attachment
mohan-bee
it doesn't give me any sense that here is the search ! like the search is hidden ?
mohan-bee
ooh ok i never used that bread crump in vscode .
! Rushabh | Linux Shill
vs code also allow you to search
! Rushabh | Linux Shill
in the breadcrump
! Rushabh | Linux Shill
it just does not show you a seach box
mohan-bee
how can i search ?
! Rushabh | Linux Shill
in vscode if you click on the breadcrumb and start typing it searches
! Rushabh | Linux Shill
but it is shallow search
! Rushabh | Linux Shill
our implemetation also search inside the dir
! Rushabh | Linux Shill
can you find any other problems
! Rushabh | Linux Shill
have you guys tried right click
! Rushabh | Linux Shill
Shared an attachment
mohan-bee
maybe we can keep the import in the center . Download | import | copy URL or you can match the style of download button ?
mohan-bee
<@452450065941004289> please take this a look .. we have something cmd+p to search files .. we need to some how express that to users . ig this design looks clean <@&1420812538421051555> comments please : https://github.com/tscircuit/monaco-code-editor/pull/48
astrimid
this crashed my browser
mohan-bee
how ?
astrimid
maybe it was out of memory panic, I don't know. when I clicked run it just froze and crashed
astrimid
maybe a coincidence
mohan-bee
working fine for me
! Rushabh | Linux Shill
https://github.com/tscircuit/tscircuit.com/pull/3966 <@757706909351411845> <@809856037376491570>
! Rushabh | Linux Shill
Preview: https://tscircuit-ffeuulirw-tscircuit.vercel.app/editor?template=blank-circuit-board
Seve
Mobile doesnt work for me, crashes
! Rushabh | Linux Shill
I can't seem to reproduce on my device.
! Rushabh | Linux Shill
<@&1420812538421051555> can you guys try in your devices
mohan-bee
maybe browser?
! Rushabh | Linux Shill
i think its a safari specific bug then
mohan-bee
+1
mohan-bee
working fine for me in safari desktop
Seve
Shared an attachment
Seve
Yea idk hard to debug
mohan-bee
bad :/
Seve
Iphone 15
! Rushabh | Linux Shill
Can you try changing browser so that we can identify if it is a browser issuse or somethig else.
! Rushabh | Linux Shill
<@&1420812538421051555> with an i phone please help!!
! Rushabh | Linux Shill
It would be nice if we get this resolved asap, i wanted to get this merged before open sauced, i believe our site will get more traffic for few days.
Rishabh
Crashes for me too, both safari and chrome
Seve
at my cpu for only a minute. I do really like it, is it possible to remove these autocomplete options
Seve
i'd like to just see tscircuit stuff, i think the other stuff generally shouldn't be used anyway
Seve
probably not possible- but would be nice- maybe we can prioritize properties or something?
Seve
not a huge deal- i think the crash is really the only thing blocking merge
Seve
oh also the mobile with the sidebar is pretty bad/hard to use- it only loads for a second for me but definitely shouldn't be showing me a sidebar
Seve
<@452450065941004289> it might be possible that this is a general issue w/ monaco and mobile or something due to types being loaded etc.
! Rushabh | Linux Shill
I think it is a ios specific bug, anyone with an iphone who would like to help me resolve this.
astrimid
FWIW a crash I had was desktop chrome. Not sure if it's the same issue. Only reproduces as I hit run. Maybe something related to workers? Some memory corruption, maybe 0-day bug, browsers shouldn't crash like that consistently. Unless it's a memory leak, which tracks as web workers have limited resources budget. But taking the whole browser down with it?
astrimid
I have 8Gib of RAM, btw
astrimid
``` getWorker(_workerId: string, label: string) { if (label === "typescript" || label === "javascript") { return new tsWorker() } return new editorWorker() }, ``` I guess it should terminate workers on some event or use singleton or cache by workerId? I guess workerId parameter exists for a reason?
astrimid
Could it be some ut with mount/unmount and dispose not being called, so workers are not disposed of? just speculating.

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗