tscircuit community
← Back to community index
# contributor·Active

Mustafa7 - @shibo https://github.com/tscircuit/...

mention https://github.com/tscircuit/core/pull/2711/files I think your checks fixes broke some tests in core(not sure) https://github.com/tscircuit/core/pull/2709

Started by Mustafa7Jul 16, 20268 messages

Discussion

Last active 2 months ago · plain text
Mustafa7original post
<@778624824875941908> https://github.com/tscircuit/core/pull/2711/files I think your checks fixes broke some tests in core(not sure) https://github.com/tscircuit/core/pull/2709
shibo
Checks dep updated?
Mustafa7
yea https://github.com/tscircuit/core/pull/2709 here, idk why it merged with failing tests
shibo
My pr did introduce breaking changes, I'm making a fix pr now
shibo
Still the bot merginf with failing tests is an issue that needs fixing
shibo
https://github.com/tscircuit/core/pull/2712
shibo
<@1079361271687807026>
Mustafa7
https://github.com/tscircuit/schematic-trace-solver/pull/672

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗