tscircuit community
← Back to community index
# contributor·Active

Seve - @anil @techmannih can help review your P...

mention mention can help review your PRs so that you have an assigned maintainer. Note that often you will need a second review before you're able to merge! For reproductions etc. techmann will merge for you if appropriate

Started by SeveJul 12, 202614 messages

Discussion

Last active 21 hours ago · plain text
Seveoriginal post
<@1507703667237716221> <@1067854999889137715> can help review your PRs so that you have an assigned maintainer. Note that often you will need a second review before you're able to merge! For reproductions etc. techmann will merge for you if appropriate
anil
hey <@1067854999889137715> could you please take a look when you get a chance https://github.com/tscircuit/cli/pull/3659 https://github.com/tscircuit/tscircuit.com/pull/3900
techmannih
<@1507703667237716221> can you please add the motivation in the description always. Why are you updating the version. This is important for a reviewer. If the reviewer doesn't know about the changes.
anil
I fixed the courtyard rotation issue in the `circuit-json-to-tscircuit` repo about 4 days ago, but it's still not fixed in `tscircuit` or the CLI. I checked it with ChatGPT's help and found that it's a dependency issue.
anil
https://github.com/tscircuit/circuit-to-svg/pull/618
techmannih
yea that make sense
techmannih
<@1507703667237716221> make sure you should go through with the our dependency flow https://docs.tscircuit.com/contributing/package-dependencies-and-auto-updates#package-dependency-flow
image.pngimage.png
techmannih
Also we have also release-tracker now. also go through with it. https://release-tracker.tscircuit.com/
techmannih
<@1507703667237716221> I dont think we need to update in tscircuit.com also, it should be automate
techmannih
please wait and see
Seve
circuit-json-to-tscircuit should probably be dynamically loaded
Seve
that would fix the issue
Seve
tscircuit/internal-dynamic-import
Seve
<@1507703667237716221> wherever it's used, probably need to make it dynamic

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗