tscircuit community
← Back to community index
# contributor·Active

Seve - @Abse in addition to shorts we can use t...

mention in addition to shorts we can use the same bitmap technique to detect things not connected in fact we might want to call it bitmap probe

Started by SeveJul 1, 202631 messages

Discussion

Last active 12 days ago · plain text
Seveoriginal post
<@398467566588264449> in addition to shorts we can use the same bitmap technique to detect things not connected- in fact we might want to call it bitmap-probe
Abse
<@757706909351411845> https://github.com/tscircuit/core/pull/2549
Abse
heading to bed , let me know if this is ok for a fix ?
Seve
do we know this doesn't create the same issue as Rishabh's fix?
Abse
I generated the Srj from my Gameboy circuit Json and routed it using welcome page on the autorouter
Abse
Routed in 34 sec
Abse
I think it's safe hopefully
Seve
oh
Seve
ok
Seve
i suspect it didn't connect the subcircuit
Seve
idk if you can easily verify that
Seve
idk worth a try i suppose
Seve
i'm trying to understand what's happening with the subcircuit logic
Abse
I can check tomorrow
Seve
ok- maybe we can merge to make it easier, the subcircuit logic is not clear
Seve
idk
Seve
i think it should be rewritten to be clear
Seve
i will take a look
Abse
Ok sg ty
Seve
yea it's not right
Seve
i'm glad we didn't merge
Seve
it actually disables a lot of DRC
Seve
Rishabh also did the same- we really can't merge PRs like this- some of the bugs being introduced would have been annoying
Seve
e.g. it allows traces to share the same name
Seve
(because it was trying to fix something unrelated)
Seve
i literally just asked the ai to go through and comment to explain each thing and i was like "oh wow, that's wrong"
Abse
Nice catch sry I just did a quick pr before sleeping, you got a better fix?
Seve
i'm just going through it step by step
Seve
yea i will try
Abse
Ok gn
Seve
yep night!

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗