← Back to community index
# contributor·Active

shibo - @techmannih https://github.com/tscircui...

mention https://github.com/tscircuit/eval/pull/2991 tests are passing except a test that needs a snapshot update

Started by shiboJun 24, 202611 messages

Discussion

Last active 19 days ago · plain text
shibooriginal post
<@1067854999889137715> https://github.com/tscircuit/eval/pull/2991 tests are passing except a test that needs a snapshot update
techmannih
Yes I have updated the snapshot
techmannih
Let's see
shibo
is this expected
techmannih
No, Still we have issues in kicad-to-circuit-json ig
techmannih
<@398467566588264449> , I'm taking that issue. I've been trying to track down where it's coming from, but I haven't found the root cause yet.
Abse
this should be fixed now no ?
techmannih
just i am checking in that pr https://github.com/tscircuit/eval/pull/3001
Abse
no there still an issue
Abse
I'm checking now
techmannih
guys that automerge i was just updating the test😅 and forgot to unable the auto merge that time https://github.com/tscircuit/eval/pull/3001

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗