← Back to community index
# contributor·Active

shibo - @! Rushabh | Linux Shill current graphs...

mention current graphs now work in runframe

Started by shiboJun 24, 202669 messages

Discussion

Last active 19 days ago · plain text
shibooriginal post
<@452450065941004289> current graphs now work in runframe
! Rushabh | Linux Shill
yes
shibo
just saying, nice work
shibo
there is another issue
! Rushabh | Linux Shill
??
shibo
this is cli snapshot command
shibo
runframe is using an old version of circuit-to-svg or circuit-json-to-spice or something
shibo
can you please investigatej
! Rushabh | Linux Shill
will take a look now
shibo
to reproduce this we have tests in the core repo for multi axis graphs
shibo
take those tests and reproduce them in the runframe or inside the cli repo in the dev server
shibo
I fixed a similar issue before, in my case I found that circuit-to-svg was outdated in runframe due to a version conflict, maybe a similar issue maybe not
! Rushabh | Linux Shill
can i have the .tsx for this
shibo
you can find a repro here: https://github.com/tscircuit/core/pull/2500/changes#diff-01156172d4924a6edc0ae8233778158e77fa6f866558542dbefcd2bd216a856c
! Rushabh | Linux Shill
https://github.com/tscircuit/schematic-viewer/pull/233 this should fix it
shibo
can you explain the issue?
shibo
a circuit-json-to-spice dep issue?
shibo
maybe move this: "circuit-json-to-spice": "^0.0.39", to "circuit-json-to-spice": "*" as a peer dep
shibo
please verify the issue also, what was the cause
! Rushabh | Linux Shill
i verified it, it was due to stale circuit-to-svg version
shibo
Move it to peer dep still
shibo
<@452450065941004289> still not working
! Rushabh | Linux Shill
i created a exampe in schematic-viewer and it worked their, must be another issue in runframe too
! Rushabh | Linux Shill
Shared an attachment
shibo
Yeah repro in cli dev server then runframe
shibo
<@452450065941004289> https://github.com/tscircuit/schematic-viewer/pull/234
shibo
did you create a repro yet?
! Rushabh | Linux Shill
i was working on a fix
! Rushabh | Linux Shill
https://github.com/tscircuit/cli/pull/3439 repro
! Rushabh | Linux Shill
Shared an attachment
shibo
can you check the simulation tab?
shibo
<@452450065941004289>
! Rushabh | Linux Shill
Shared an attachment
shibo
delete your node modules or something, i don't have that ammeter issue
! Rushabh | Linux Shill
the symbo issus is also present in tscircuit.com
! Rushabh | Linux Shill
https://github.com/tscircuit/cli/pull/3439 repro
! Rushabh | Linux Shill
fixed
! Rushabh | Linux Shill
lets goooo
! Rushabh | Linux Shill
Shared an attachment
! Rushabh | Linux Shill
`circuit-json` and `props` were outdated 🤦
! Rushabh | Linux Shill
<@778624824875941908>
shibo
Why are they not peer deps?
shibo
This is a separate issue you could fix
shibo
Remove those two from deps, so we take them from the tscircuit dep. Then show the pr to seve
shibo
Because im kot sure if thats desirable
shibo
<@452450065941004289> still not working in the latest tscircuit version using the tsci dev server
! Rushabh | Linux Shill
hmm
shibo
can you create a different kind of repro? a playwright test that uses the tsci dev command
shibo
actually the repro you did is not accurate
shibo
you need to be using the bundled runframe version cli uses in the dev server
! Rushabh | Linux Shill
it is working in tsci dev
! Rushabh | Linux Shill
Shared an attachment
shibo
maybe I have a stale cache
! Rushabh | Linux Shill
yeah
shibo
<@452450065941004289> it worked in a different browser 🎉
shibo
cache issue
shibo
so now we gotta make sure this doesn't happen again
shibo
this may be a solution
! Rushabh | Linux Shill
adding them in peer dep
! Rushabh | Linux Shill
will that work??
! Rushabh | Linux Shill
why cant we do something like this
! Rushabh | Linux Shill
or to runframe
! Rushabh | Linux Shill
so we can use them as peer dep downstream
! Rushabh | Linux Shill
<@757706909351411845>
! Rushabh | Linux Shill
Shared an attachment
Seve
It has to be to core not runframe
Seve
The doc with the flowchart should be updated prior to the implementation pr

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗