tscircuit community
← Back to community index
# contributor·Active

Seve - @shibo @Anas HUGE bug in the copper pour...

mention mention HUGE bug in the copper pour solver. It accepts a connectivity map key that is NOT the subcircuit connectivity map key????? Massive footgun, please fix!!!! I tried to recommend this library to someone on X and I couldn't believe how bad that was!!!!

Started by SeveJun 24, 202617 messages

Discussion

Last active 19 days ago · plain text
Seveoriginal post
<@778624824875941908> <@756504518417711104> HUGE bug in the copper pour solver. It accepts a connectivity map key that is NOT the subcircuit connectivity map key????? Massive footgun, please fix!!!! I tried to recommend this library to someone on X and I couldn't believe how bad that was!!!!
Seve
I actually spent a while on this because i couldn't believe this API design decision
Seve
I generated a usage section for the README and it was askin gthe user to generate a connectivity map prior to passing in the circuit json!
Seve
this is totally wrong! It doesn't make any sense! Generating a connectivity map is not guaranteed to be deterministic and is not a requirement of getting a copper pour!!!!
Seve
Just accept `subcircuit_connectivity_key` or whatever the appropriate key is- this is a massive footgun as is!!!!
Seve
i will also say- POOR README AND NO COSMOS ON THAT PROJECT!!!! This is below our standards!!!!
shibo
https://github.com/tscircuit/copper-pour-solver/pull/53
shibo
<@757706909351411845>
Seve
https://x.com/seveibar/status/2069636043352293546?s=46
shibo
<@757706909351411845> the snapshot change is a fix
shibo
Those vias are connected to gnd as far as I knwo
Seve
they look like unassigned vias
Seve
i would double check
Seve
that board is a viagrid/assignable via style board iirc
shibo
Shared an attachment
image.pngimage.png
shibo
<@757706909351411845> https://github.com/tscircuit/core/pull/2503 <@757706909351411845>
shibo
<@757706909351411845> https://github.com/tscircuit/props/pull/702

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗