← Back to community index
# contributor·Active

Mustafa7 - @shibo https://github.com/tscircuit/...

mention https://github.com/tscircuit/eval/actions/runs/27974473928/job/82788627726?pr=2995 https://github.com/tscircuit/eval/pull/2995

Started by Mustafa7Jun 23, 202610 messages

Discussion

Last active 20 days ago · plain text
Mustafa7original post
<@778624824875941908> https://github.com/tscircuit/eval/actions/runs/27974473928/job/82788627726?pr=2995 https://github.com/tscircuit/eval/pull/2995
techmannih
https://github.com/tscircuit/eval/pull/2995
techmannih
I am not sure this is correct fix but yesterday i did confirm from shibo, looks good for him
shibo
I'm not sure about the font issue, but the test changes are ok
techmannih
Fonts are changing due to kicad fix i think
Rishabh
Font's are changing cause the kicad-mod-cache repo has been migrated from `kicad-component-converter` to `kicad-to-circuit-json`
shibo
<@809856037376491570> can this be merged: https://github.com/tscircuit/eval/pull/2995
shibo
please review
Rishabh
https://discord.com/channels/1233487248129921135/1515328809979740281/1518848791195815936 The font doesn't look like a 1.5 times in the change <@398467566588264449>
foobar
I independently arrived at similar fixes from 2995 in this pr: https://github.com/tscircuit/eval/pull/2999 (I didn't notice this thread or that 2995 had additional files in the PR) - it looks like 2995 was closed by the bot, this pr unbundles the bot's changes to package.json and only fixes the test bugs, with a comprehensive ai explanation of what happened. One difference I should mention between 2999 and 2995 is 2995 actually removed the cdn fetch for the eecircuit bundle and uses a local test fixture, which changed the test behavior from live-cdn test. Mine continues to fetch from the live cdn (I actually think remote server tests during CI is incorrect behavior but opted not to change it without further discussion). I know you all are really busy right now so hope this pr and summary is helpful.

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗