← Back to community index
# contributor·Active

techmannih - https://github.com/tscircuit/eval/...

https://github.com/tscircuit/eval/pull/2989

Started by techmannihJun 21, 202615 messages

Discussion

Last active 21 days ago · plain text
techmannihoriginal post
https://github.com/tscircuit/eval/pull/2989
shibo
can you please investigate? it worked after my pr
techmannih
Yes i am looking into it
techmannih
<@778624824875941908> this repro test was relying on a live CDN response and assuming the older /npm/... import shape. The CDN now returns an absolute jscdn URL instead, so the test had gone stale,
techmannih
we can fix it by replacing the live fetch with a deterministic fixture while keeping the assertions focused on the actual transform behavior.
shibo
Ok ig
shibo
Just tag seve for review
techmannih
can you take a look once https://github.com/tscircuit/eval/pull/2991
shibo
change the name of the constants, instead of current etc call it what it is
techmannih
<@757706909351411845> https://github.com/tscircuit/eval/pull/2991
techmannih
<@809856037376491570> can you take a look at this pr. Otherwise the core should not be updated in eval ig
techmannih
https://github.com/tscircuit/eval/pull/2995
techmannih
<@757706909351411845>
techmannih
I have fixed that test in previous pr
techmannih
<@1079361271687807026>

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗