Anas - @techmannih @mohan-bee @! Rushabh | Linu...

I see this issue after updating schematic-symbols in core

will take a look

For an NPN transistor, the pin numbering depends on the specific transistor model and package. There is no universal pin order.

What should we follow <@1067854999889137715>

1 = Emitter, 2 = Base, 3 = Collector seems to be the most commonly used

<@756504518417711104>

yeah thats what core/props follow

So make sure schematic-symbols are following same pattern

core follow different pattern ```ts initPorts() { const pinAliases = { pin1: ["collector", "c"], pin2: ["emitter", "e"], pin3: ["base", "b"], } ```

maybe we need to update core to match with props. also symbols they are mapped incorrectly. pin1: emitter, pin2: collector, pin3: base.

yes

schematic-symbols and core both need to be changed ig

https://github.com/tscircuit/schematic-symbols/pull/429

<@1067854999889137715>

Did we follow this rn?

we follow this rn for npn but not pnp

we can just fix pnp to follow the same ig currently pnp

https://github.com/tscircuit/schematic-symbols/pull/430

<@756504518417711104>

now we need to fix the same in core

https://github.com/tscircuit/props/pull/698

<@452450065941004289>, make sure you get a review from Rishabh or Seve. Previously We got stuck on this once before and that creates a lot of issues iirc

the updated schematic-symbol aligne with this image

in order to update the core we need to update to props first

https://github.com/tscircuit/props/pull/698 <@809856037376491570> can you take a look

<@809856037376491570>