← Back to community index
# contributor·Active

Rishabh - @! Rushabh | Linux Shill Did you figu...

mention Did you figure out what those traces are being dropped? We need to update the core with the latest deps version, cause that is blocking the tscircuit release pipeline

Started by RishabhJun 16, 20266 messages

Discussion

Last active 27 days ago · plain text
Rishabhoriginal post
<@452450065941004289> Did you figure out what those traces are being dropped? We need to update the core with the latest deps version, cause that is blocking the `tscircuit` release pipeline
! Rushabh | Linux Shill
The traces were dropped because imported trace inflation assumed a 1:1 mapping between source_trace and pcb_trace, but the newer kicad-to-circuit-json output uses 1:many.
! Rushabh | Linux Shill
will push the change now for review
! Rushabh | Linux Shill
tests are failing the tests are flaky because they assert exact rendered images for large imported trace networks whose element ordering is not guaranteed to be stable across runs.
! Rushabh | Linux Shill
https://github.com/tscircuit/core/pull/2450
! Rushabh | Linux Shill
i removed the snapshot comparisons

Want to add to the conversation?

Reply in Discord so your notes stay connected to the source.
Continue in Discord ↗