mohan-bee - Hey @Abse , can you help me with t...

Where do you want this change to be made — in core or somewhere else?

<@1238122660345548882> can you link the issue with the pr

ig this needs to implement across 2-3 repos core, circuit to canvas, circuit to svg

still trying to figure out solution

.

https://github.com/tscircuit/tscircuit/issues/3277

yea thanks do you add the spec?

yep

yea so next pr should be in circuit-to-svg

it is the right place in the pipeline

https://github.com/tscircuit/circuit-to-svg/pull/566

now seve said about the implementation is wrong

I tried to look into this implementation to understand what exactly we need according to the issue.

In circuit-to-svg, I changed the board color fix so it does not change the normal color override system. pcb_board.solder_mask_color and pcb_board.silkscreen_color will be applied only when showSolderMask: true

damn sorry for that i was totally forgot about it that time

no issue ! can we reopen this again ?

but i am still confused about the expected behaviour !

let me check it once again

may be take a look at the pr https://github.com/tscircuit/circuit-to-svg/pull/566 https://github.com/tscircuit/circuit-to-canvas/pull/240

you need to add the solder_mask_color in circuit json for pcb board first

that is added already

https://github.com/tscircuit/circuit-json/pull/588

<@1238122660345548882> We already have solder mask support for boards, platedhole, pcbhole,smtpads. Could you study how it works across circuit-to-svg, core, circuit-to-canvas, pcb-viewer, and the 3D viewer? That investigation would be very helpful if you're planning to tackle this issue. I'm still working on understanding the user expectations and planning the best approach for that issue

Without studying the existing implementation, it will be difficult to understand what's actually going on there and how the different parts of the stack work together.

okay thanks for the take.

let me go through that again

<@1067854999889137715> can you review this draft one : https://github.com/tscircuit/circuit-to-canvas/pull/247 also idk how well this approach is !! in pcb-viewer the soldermask is rendered only when drawSoldermask is true, also the 3d viewer works in the same way too .. the important part is how existing soldermask works: colorMap.soldermask is the base board mask surface. colorMap.soldermaskOverCopper is used for copper covered by soldermask, like covered pads/plated holes. colorMap.copper remains exposed pad/trace color. ** only the board fill passed to drawBoardSoldermask changes. Everything else still uses the existing realistic soldermask system.** i have also added some different scenario snapshots , without by drawSoldermask: false, drawSoldermask: true (with new color if provided) , drawSoldermask: true(without any color provided) !!

Yes I will check it, now I am afk