Seve - hello everyone, i need a maintainer to m...

<@757706909351411845> https://github.com/tscircuit/core/pull/1848

<@757706909351411845> is it done or i need to add anywhere? https://linear.app/tscircuit/issue/TSC-327/implement-displayname-for-all-normal-components

test on tscircuit.com

???

after update the tscircuit in tscircuit.com

looks like bad dep verison for autorouter or something

okay, need to update in core first?

update what?

make sure the autorouter version you're using in that project matches the one already in core. Use npm ls

yep

what is mfn?

we never defined in props

manufacturer part number...

yes but it not defined in props......do we need to add it, it give type error otherwise

yea we can add it!

it is a common shorthand

https://github.com/tscircuit/props/pull/562

is it not in commonlayoutprops?

where is manufacturerPartNumber defined

manufacturerPartNumber is using individually for all

why would we define them in separate locations. mpn/manufacturerPartNumber is not related to layout

honestly a bit disappointed because maintainers are supposed to be keep code quality high and it seems like you sort of just did something really hacky

but i'm glad you found the issue in the first place ig

ahh sorry, i was add it individually but when you mentioned it is common, then added in commonlayout

https://github.com/tscircuit/props/pull/563

this is still the wrong location

are you reviewing your code before you request review?

yes, but manufacturePartNo is also defined as same place for some component

add it as a common component prop, not a common layout prop

😵‍💫

my bad, i was thinking all component inherit the CommonLayoutProps 😵‍💫 damm

https://github.com/tscircuit/props/pull/564

number is missing in the component’s name when I convert the circuit-json to KiCad and check the schematic view.

Yea seems like a bug

yep i try to fix it.

https://github.com/tscircuit/circuit-json-to-kicad/pull/70

I was getting this issue when I was using https://circuit-json-to-kicad.com to convert Circuit JSON to KiCad and viewing the schematic, and after fixing it, I followed the same process and got the correct output, which is what I mentioned.

Create a repro and don't update unnecessary snapshots

you updated every snapshot in the project

don't even fix it right away- implement the repro first

just PR a test with the snapshot so that i can see the issue

you updated 100 snapshots unnecessarily

yep due to BUN_UPDATE_SNAPSHOTS=1

https://github.com/tscircuit/circuit-json-to-kicad/pull/73

now fixed

yes, i made a repro first and send you a pr after fix? is there something wrong? that is repro https://github.com/tscircuit/circuit-json-to-kicad/pull/71

You merged without approval? Why?

you said first make a repro then fix it.

Dont skip approval

sure sorry for this time

new issue for chip P1

https://github.com/tscircuit/circuit-json-to-kicad/pull/58/files

<@757706909351411845> https://github.com/tscircuit/circuit-json-to-kicad/pull/82 https://github.com/tscircuit/core/pull/1865

nice work on these <@1067854999889137715>

some dep issue in the tscircuit.com. Idk why it is not updating. can you tell me how can i get proper dep update in tscircuit.com

I don’t think so. We had already implemented maxVoltageRating / capacitance in the schematic view before 2 month ago i think, but it is still not showing on tscircuit.com.

<@757706909351411845>

I think u just have to install that dep

seems like core issue?

https://github.com/tscircuit/core/pull/1877

I try to changes the color of board then found it the background color always is black. look like a issue ????

this should be work like this

<@757706909351411845> https://github.com/tscircuit/circuit-json/pull/447

is the @tscircuit/capacity-autorouter private repo?

no

it is tscircuit-autorouter

displayname and manufacturepartno both work locally

maybe try to carefully reproduce the customer issue more? Maybe an issue with the group?

yes i just copied which is give by him https://discord.com/channels/1233487248129921135/1437566965421047829/1466344901573742669

once can you check it. both are working well right now. i am using the code which is provide the customer https://tscircuit.com/editor?package_id=ebeb9aec-1c80-45e6-82e6-15613e34c3f6

<@757706909351411845>

can you communicate to the user that you couldn't reproduce and send them that link? ty

Yes

But this is reproduce

ah ok then fix it?

i'm confused

It's fixed

This is a link where both are working well

<@1067854999889137715> If it's working, then tell the customer you weren't able to reproduce their issue

if it's not working, then fix it

what is the issue?

<@757706909351411845> The user wants the net label to use displayName instead of name when displayName is available. So we would need to define a clear priority, for example: manufacturerPartNumber > displayName > name, or displayName > manufacturerPartNumber > name What do you think—should we support this behavior? And if yes, which priority makes more sense?

<@757706909351411845>

What? Name and manufacturerPartNumber display in different locations

Not relevant

No

User want this

displayName is prefered over name, manufacturerPartNumber is put in a totally different place

also <@1067854999889137715> i'm literally going to derank you for your shitty short messages. Do not waste my time

i'm dead serious, wtf is this

explain yourself complete, in full sentences, with screenshots. This is the last warning. I don't have time for a million messages on such a simple concept

displayName is shown instead of name when provided. manufacturerPartNumber is shown in a different location

that is the intended behavior

I know this "displayName is shown instead of name when provided. manufacturerPartNumber is shown in a different location". But the user desired something different. I was just asking you. do we need to support or not. The user wants the net label to use displayName instead of name when displayName is available.

Yes net labels can also have display names!

Thank you