Techmannih - @Seve there are some concave and s...

yes we should add those flags

is there any default use like 0402x2 which is for default convex or concave

probably convex is the default

Sorry I am founding lot of unwanted thing in 3d-viewer when i try to refactor with circuit-to-canvas.

I think KiCad is using clockwise pin numbering. The green color is from KiCad, and the red one is ours.

Hmm it seems like just a bug with the conversion not related to clockwise/ccw

Because if we’re converting custom symbols it should just adopt whatever we say

yes for custom symbols, the conversion should follow exactly what we define

<@757706909351411845> yep, there is the rotation issue, we doest support the rotation to the polygon smtpad. do we need to add support rotation. ???

i don't know what we need to do exactly, but polygons are never represented with rotations in circuit json

it's not tricky

yep its fixed, i was thinking in different way. ty!

https://github.com/tscircuit/kicad-to-circuit-json/pull/36

Removing incorrect logic handling that was affecting the pill-shaped plated hole. https://github.com/tscircuit/kicad-to-circuit-json/pull/38

Yes, I have added rotation support for circular holes and rectangular pads. It is also being generated in the circuit JSON, but I still need to figure out what the issue is in this case and why it is not working. I am also looking on it.

sg!

https://github.com/tscircuit/circuit-to-canvas/pull/184

I’ve fully switched to using the transformation matrix for the plated hole. All ctx.translate, ctx.save, ctx.restore, and ctx.rotate calls have been removed. I’ll address the rotation handling separately later on. Could you please review? https://github.com/tscircuit/circuit-to-canvas/pull/189

i'm not really sure what to do because i've given a lot of feedback to PRs but the quality doesn't seem to be getting better, i just don't have time to review PRs with a lot of mistakes

you have single letter functions and variables like `mat`

you also used the word `rotation` for a fourth time

these are matrix and radian, yeah i change them.

No, it was using ccwRotationDegrees.

oh variable name, it was param

Can you reopen it? I’ve applied the changes.

you need to get another reviewer before requesting my reviews, you need to get two reviews now for your PRs

the reviews must come from a maintainer

sure