Techmannih - @Seve Should keepouts be drawn usi...

Do also need to add support for courtyard-outline and courtyard-polygon?

Yep courtyard works, we don’t need polygon yet

https://github.com/tscircuit/circuit-to-svg/pull/464

👉 Nothing is allowed inside a keepout area. ❌ Don’t place tracks ❌ Don’t place copper ❌ Don’t place vias ❌ Don’t place other components

<@757706909351411845> https://github.com/tscircuit/circuit-to-canvas/pull/100 https://github.com/tscircuit/core/pull/1814

it should be represent in between the pads/ holes?

it is looks same in cts right now

well you should make a proper snapshot test then

there are plenty of tests that show circuit-to-svg as well

yea

better but you're not supposed to have a dashed border

is should have any border or no boarder?

yea like that but also a slight transparent red

as the background

cool

yep

<@757706909351411845> https://github.com/tscircuit/props/pull/550 https://github.com/tscircuit/core/pull/1818

<@757706909351411845> do not need for pullup and pulldown properties to jumperProps. for this issue? https://linear.app/tscircuit/issue/TSC-277/pullupfor-pullupto-pulldownfrom-pulldownto-for-jumpers-same-as

there is an issue in the spec, it is technically solvable but i'm cancelling

<@757706909351411845> https://github.com/tscircuit/pcb-viewer/pull/592

I added abse to the review

bottom layer silkscreen and text issue in kicad

i'm not sure?

depends on how kicad styles bottom silkscreen

open it in kicad

yes

is the courtyard_circle should be filled in pcb-viewer?

Check kicad but probably not supposed to be filldd

yes sure

locked is filled

Just open kicad

Create a courtyard

Probably is not filled

okay

true this is not filled

<@757706909351411845> , should stroke_width be optional for pcb_courtyard_outline?

stroke_width shouldn't exist on pcb_courtyard_outline

neither should is_stroke_dashed or is_closed

or color

yep

i am removing them

https://github.com/tscircuit/circuit-json/pull/456

<@757706909351411845> i m missing merge access in circuit-json

merged

looks like a bug to me? both bottom and top color for the courtyard looks opposite

i don't know what you mean because none of these images are labeled

in the snapshots of KiCad and circuit-json. In circuit-json, we are using the top courtyard, but in KiCad the bottom courtyard color is being rendered.

<@1067854999889137715> open excalidraw and annotate the images like so:

i still don't understand, but if you think it's a real bug you can go directly to PR of course- but it is important to communicate concretely

yes there is one more issue in the kicad bottom courtyard is top of top layer courtyard

yes and in this snapshot looks like we are using the top courtyard, but in KiCad the bottom courtyard color is being rendered

<@1067854999889137715> i literally don't know what you're saying- we had this discussion already- i do not know what you're talking about because i do not have the full context of what you have done or seen. _ANNOTATE THE SCREENSHOTS_

you're saying that blue, in kicad, represents bottom courtyard? So then our top courtyard becomes a bottom courtyard? Yes that seems like a bug

Yes — I’m saying that

I’ve figured it out now — this isn’t the original issue we thought it was. The actual problem is a layer ordering issue: the bottom courtyard is being rendered above the top courtyard. Because of this, it appears like a courtyard mismatch, but it’s not a color or mapping issue.

<@757706909351411845> The courtyard is not working in the docs. Is there any dependency issue? I added support for it everywhere almost 4 days ago. https://github.com/tscircuit/docs/pull/436

Write a test in the svg.tscircuit.com rrpo

https://github.com/tscircuit/svg.tscircuit.com/pull/978

this should be easy to fix now

Can you check it now I have updated https://github.com/tscircuit/docs/pull/764

<@757706909351411845> A user created some issue. do we need to take action on them

Idk evaluate if theyre valid

We should always examine user reported issues if theyre not slop, that guy is legit

exactly yea, I checked his profile. he seems like a good open-source contributor

can you check it https://github.com/tscircuit/circuit-json-to-kicad/pull/373 https://github.com/tscircuit/core/pull/2625

updated, can you check now

<@757706909351411845>

These both are the user issue. I add the reference of issue

Can you check it https://github.com/tscircuit/core/pull/2631 https://github.com/tscircuit/circuit-json-to-kicad/pull/375

Can you check it now https://github.com/tscircuit/core/pull/2631

Updated

Can you check it now

<@757706909351411845> https://github.com/tscircuit/ti/pull/68 we need your suggestion, can you check it

https://github.com/tscircuit/easyeda-converter/pull/407 trying to fix easyeda issue, can you check it also

<@1067854999889137715> unrelated but we discussed figuring out footprinter strings from jlcpcb imports- we still need that- the codebase has massive footprints

yea we can use as footprint string footprint="jlcpcb:C44346038"

<@1067854999889137715> that's not what i mean. We're supposed to automatically derive a footprinter string from jlcpcb footprints via IoU matching

yea we have so many different ways to do the same thing that I completely forgot about this one.

there's still some work left on this. we still need to automatically load it using AI so it can suggest the closest matching footprinter string from JLCPCB. I'll take a look into that as well.

Sorry Sorry we keep getting high priority work, especially TI-related tasks schematic and important fixes, so sometimes things get pushed back

BTW we can use qfn40,

https://github.com/tscircuit/fast-footprint-compare/pull/3

Boom 💥

Then name should be discover from footprinter. I think?

? Wdym

It should be discover from footprinter?

Why would we want that, what would that do?

I think discovering the footprint string from footprinter which should closely match with jlcpcb part no

Why would anyone want that

Please put yourself into the mindset of a user

Why would anyone want that

Or youre communicating extremely poorly